[meta-freescale] [meta-fsl-arm][PATCH] u-boot-fslc: Add tag to git SRC_URI

[John Weber]

On 12/9/13 10:35 AM, Otavio Salvador wrote:
> Hello Gary,
>
> On Mon, Dec 9, 2013 at 2:35 PM, Gary Thomas <gary at mlbassoc.com> wrote:
>> On 2013-12-09 09:28, John Weber wrote:
>>> On 12/9/13 10:26 AM, Gary Thomas wrote:
>>>> On 2013-12-09 09:10, John Weber wrote:
>>>>> From: Dan McGregor <danismostlikely at gmail.com>
>>>>>
>>>>> Bitbake now checks for the commit in the master branch by default.
>>>>> Explictly set the tag where SRCREV is expected.
>>>>>
>>>>> Signed-off-by: John Weber <rjohnweber at gmail.com>
>>>>> ---
>>>>>    recipes-bsp/u-boot/u-boot-fslc_2013.10.bb |    2 +-
>>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>>>
>>>>> diff --git a/recipes-bsp/u-boot/u-boot-fslc_2013.10.bb
>>>>> b/recipes-bsp/u-boot/u-boot-fslc_2013.10.bb
>>>>> index 73d4371..56c3265 100644
>>>>> --- a/recipes-bsp/u-boot/u-boot-fslc_2013.10.bb
>>>>> +++ b/recipes-bsp/u-boot/u-boot-fslc_2013.10.bb
>>>>> @@ -11,7 +11,7 @@ PROVIDES += "u-boot"
>>>>>    PV = "v2013.10"
>>>>>
>>>>>    SRCREV = "079e214888279518ce061c71238a74a0c3db2c28"
>>>>> -SRC_URI = "git://github.com/Freescale/u-boot-imx.git"
>>>>> +SRC_URI =
>>>>> "git://github.com/Freescale/u-boot-imx.git;tag=patches-2013.10"
>>>>>
>>>>>    S = "${WORKDIR}/git"
>>>>>
>>>>>
>>>>
>>>> Can you please change this so the branch name can be overridden, as
>>>> in the patches I sent for the other recipes?
>>>>
>>> Hi Gary - I'm not sure if that would be useful since the u-boot recipe
>>> does not depend on a .inc file.  Where would the override come from?
>>
>>  From .bbappend files in my layers (I have a private BSP layer which
>> extend the meta-fsl-arm* layers).
> I think what John means is that you'll end rewriting the SRC_URI, no?
>
> Do you have an use example where you'd need it?
>
I think he means to do something like this:

GITTAG ??= "patches-2013.10"
SRC_URI = "git://github.com/Freescale/u-boot-imx.git;tag=${GITTAG}"

This way he can override GITTAG in his .bbappend, correct?