[meta-freescale] [PATCH 13/27] lmsensors-apps: add required runtime dependencies

Otavio Salvador otavio at ossystems.com.br
Fri Nov 30 03:12:20 PST 2012


On Fri, Nov 30, 2012 at 1:57 AM, Luo Zhenhua-B19537 <B19537 at freescale.com>wrote:

> > -----Original Message-----
> > From: meta-freescale-bounces at yoctoproject.org [mailto:meta-freescale-
> > bounces at yoctoproject.org] On Behalf Of Daiane Angolini
> > >
> > > Signed-off-by: Zhenhua Luo <b19537 at freescale.com>
> > > ---
> > >  .../lm_sensors/lmsensors-apps_3.3.2.bb             |    4 +++-
> > >  1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/recipes-extended/lm_sensors/lmsensors-apps_3.3.2.bb
> > > b/recipes-extended/lm_sensors/lmsensors-apps_3.3.2.bb
> > > index 57a6f3e..62da814 100644
> > > --- a/recipes-extended/lm_sensors/lmsensors-apps_3.3.2.bb
> > > +++ b/recipes-extended/lm_sensors/lmsensors-apps_3.3.2.bb
> > > @@ -9,7 +9,7 @@ LICENSE = "GPLv2 & LGPLv2.1"
> > >  LIC_FILES_CHKSUM =
> > "file://COPYING;md5=751419260aa954499f7abaabaa882bbe \
> > >
> > file://COPYING.LGPL;md5=4fbd65380cdd255951079008b364516c"
> > >
> > > -PR = "r1"
> > > +PR = "r2"
> > >  PACKAGE_ARCH = "${MACHINE_ARCH}"
> > >
> > >  SRC_URI = "http://dl.lm-sensors.org/lm-sensors/releases/lm_sensors-
> > ${PV}.tar.bz2"
> > > @@ -37,6 +37,8 @@ PACKAGES =+ "lmsensors-scripts"
> > >
> > >  FILES_lmsensors-scripts = "${bindir}/*.pl ${bindir}/ddcmon
> > ${sbindir}/fancontrol* ${sbindir}/pwmconfig ${sbindir}/sensors-detect"
> > >  RDEPENDS_lmsensors-scripts += "lmsensors-sensors perl bash"
> > > +RDEPENDS_lmsensors-apps += "perl-module-strict perl-module-vars perl-
> > module-warnings-register perl-module-warnings"
> > > +RDEPENDS_lmsensors-scripts += "perl-module-fcntl perl-module-exporter
> > perl-module-xsloader perl-module-exporter-heavy perl-module-file-basename
> > perl-module-constant"
> > You added runtime dependencies for lmsensors-scritps, but from subject
> > only lmsensors-apps is changed
> [Luo Zhenhua-B19537] the prefix of the subject means the name of updated
> recipe, if the name of all impacted binary packages is required to be
> indicated in the subject, I can re-create a patch.
>


In the shortlog (the subject) you may include it when it is easy to express
it but when it is difficult to come with a short description that describes
it properly you can do it in long commitlog

>From the patch, I'd use:

--3<--
lmsensors-apps: Add required rdepends of perl modules to
lmsensors-{apps,scripts}

 * lmsensors-apps: Add perl-module-strict perl-module-vars
perl-module-warnings-register
perl-module-warnings
 * lmsensors-scripts: perl-module-fcntl perl-module-exporter
perl-module-xsloader
perl-module-exporter-heavy perl-module-file-basename perl-module-constant
-- 3<--

But it is up to you. The point in describe it is when in future someone
wants to find who or why a change has been done. The more descriptive the
commit log is the easier is to find the need information in future.

Regards,

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/meta-freescale/attachments/20121130/9df87ba5/attachment.html>


More information about the meta-freescale mailing list