[meta-freescale] [meta-fsl-arm][PATCH v2] linux-imx: Add a patch to fix perf compilation issue.

[McClintock Matthew-B29882]

On Wed, Dec 19, 2012 at 4:47 AM, Otavio Salvador
<otavio at ossystems.com.br> wrote:
> On Wed, Dec 19, 2012 at 8:41 AM, Noor, Ahsan <noor_ahsan at mentor.com> wrote:
>> From: Noor Ahsan <noor_ahsan at mentor.com>
>>
>> * Perf gived compilation error
>>   CC builtin-sched.o
>>     builtin-sched.c: In function ‘get_cpu_usage_nsec_parent’:
>>   builtin-sched.c:399:16: error: storage size of ‘ru’ isn’t known
>> * Added a patch from linux kernel git repo commit id
>>   7b78f13603c6fcb64e020a0bbe31a651ea2b657b which include resource.h
>>   file in builtin-sched.c.
>> * Bump PR.
>> * Verified it on Saberlite machine.
>>
>> Signed-off-by: Noor Ahsan <noor_ahsan at mentor.com>
>
> We're almost OK, just minor issues...

Can I ask you do this for the meta-fsl-ppc version as well? Use the
upstream patch?

-M

>
>> ---
>>  .../linux/linux-imx/fix_getrusage_for_perf.patch   |   33 ++++++++++++++++++++
>>  recipes-kernel/linux/linux-imx_3.0.35.bb           |    5 ++-
>>  2 files changed, 37 insertions(+), 1 deletion(-)
>>
>> diff --git a/recipes-kernel/linux/linux-imx/fix_getrusage_for_perf.patch b/recipes-kernel/linux/linux-imx/fix_getrusage_for_perf.patch
>> new file mode 100644
>> index 0000000..24a311c
>> --- /dev/null
>> +++ b/recipes-kernel/linux/linux-imx/fix_getrusage_for_perf.patch
>> @@ -0,0 +1,33 @@
>> +commit 7b78f13603c6fcb64e020a0bbe31a651ea2b657b
>> +Author: Markus Trippelsdorf <markus at trippelsdorf.de>
>> +Date:   Wed Apr 4 10:45:27 2012 +0200
>> +
>> +    perf tools: Fix getrusage() related build failure on glibc trunk
>> +
>> +    On a system running glibc trunk perf doesn't build:
>> +
>> +        CC builtin-sched.o
>> +    builtin-sched.c: In function ‘get_cpu_usage_nsec_parent’: builtin-sched.c:399:16: error: storage size of ‘ru’ isn’t known builtin-sched.c:403:2: error: implicit declaration of function ‘getrusage’ [-Werror=implicit-function-declaration]
>> +        [...]
>> +
>> +    Fix it by including sys/resource.h.
>> +
>> +    Signed-off-by: Markus Trippelsdorf <markus at trippelsdorf.de>
>> +    Cc: Peter Zijlstra <a.p.zijlstra at chello.nl>
>> +    Link: http://lkml.kernel.org/r/20120404084527.GA294@x4
>> +    Signed-off-by: Ingo Molnar <mingo at kernel.org>
>> +
>> +Upstream-Status: merged
>
> Please check the compatible Upstream-Status values at
> http://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines#Patch_Header_Recommendations
> and adjust the patch.
>
> ...
>> --- a/recipes-kernel/linux/linux-imx_3.0.35.bb
>> +++ b/recipes-kernel/linux/linux-imx_3.0.35.bb
>> @@ -3,7 +3,7 @@
>>
>>  include linux-imx.inc
>>
>> -PR = "${INC_PR}.5"
>> +PR = "${INC_PR}.6"
>>
>>  COMPATIBLE_MACHINE = "(mx6)"
>>
>> @@ -13,3 +13,6 @@ LOCALVERSION = "-12.09.01+yocto"
>>
>>  # iMX6Q SabreLITE changes done by Boundary Devices
>>  SRC_URI_append_imx6qsabrelite = " file://sync-boundary-changes.patch"
>> +
>> +SRC_URI += "file://fix_getrusage_for_perf.patch \
>> +           "
>
> I'd prefer if SRC_URI += would be put *before* the SabreLITE one as it
> would be read *before* than board specific changes.
>
> Please check those minor issues and please send a v3.
>
> Regards,
>
> --
> Otavio Salvador                             O.S. Systems
> E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
> Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
> _______________________________________________
> meta-freescale mailing list
> meta-freescale at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale