[meta-freescale] [PATCH 8/9] cryptodev: skip arch QA since kernel might not match for 64-bit kernels on 32-bit rfs

[Otavio Salvador]

On Thu, Dec 6, 2012 at 12:10 PM, <b28495 at freescale.com> wrote:

> From: Yashpal Dutta <yashpal.dutta at freescale.com>
>
> Signed-off-by: Yashpal Dutta <yashpal.dutta at freescale.com>
>

This is a new recipe so it could be done together with the addition of
it... more bellow...


> ---
>  recipes-kernel/cryptodev/cryptodev_1.5.bb |   18 ++++++++++++++++++
>  1 files changed, 18 insertions(+), 0 deletions(-)
>
> diff --git a/recipes-kernel/cryptodev/cryptodev_1.5.bbb/recipes-kernel/cryptodev/
> cryptodev_1.5.bb
> index 0696e2a..636bb54 100644
> --- a/recipes-kernel/cryptodev/cryptodev_1.5.bb
> +++ b/recipes-kernel/cryptodev/cryptodev_1.5.bb
> @@ -15,3 +15,21 @@ SRC_URI = "git://
> repo.or.cz/cryptodev-linux.git;protocol=git \
>  EXTRA_OEMAKE='KERNEL_DIR="${STAGING_KERNEL_DIR}" PREFIX="${D}"'
>
>  S = "${WORKDIR}/git"
> +python () {
> +       ma = d.getVar("DISTRO_FEATURES", True)
> +       arch = d.getVar("OVERRIDES", True)
> +
> +       # the : after the arch is to skip the message on 64b
> +       if not "multiarch" in ma and ("e5500:" in arch or "e6500:" in
> arch):
> +               raise bb.parse.SkipPackage("Building the kernel for this
> arch requires multiarch to be in DISTRO_FEATURES")
>

It would be good if the comment could clarify the if in more detail. From
reading it, it seems e5500 and e6500 require multiarch to have this working
but it is not easy to spot it reading your comment or code.


> +       promote_kernel = d.getVar('BUILD_64BIT_KERNEL')
> +
> +       if promote_kernel == "1":
> +               d.setVar('KERNEL_CC_append', ' -m64')
> +               d.setVar('KERNEL_LD_append', ' -melf64ppc')
>

Couldn't it be done using something as:

KERNEL_CC_tune-powerpc64_append = ' -m64'

As in case you use multiarch you'll be using the 64bit tune so you could
avoid the kernel checking. Am I missing something?


> +       error_qa = d.getVar('ERROR_QA', True)
> +       if 'arch' in error_qa:
> +               d.setVar('ERROR_QA', error_qa.replace(' arch', ''))
> +}
>

The commit log is not accurately describing what you arre fixing it. The qa
handling is done late and more changes are done above.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.yoctoproject.org/pipermail/meta-freescale/attachments/20121206/a1b51f89/attachment.html>