[meta-freescale] Help with variable expansion in bbappend

[Alex Gonzalez]

Hi Otavio,

For the patch testing, apart from some of the packages with freescale
EULA, any preference on image type and machine to test the build with?

I am going for core-image-minimal and imx53qsb.

Thanks,
Alex

On Fri, Nov 30, 2012 at 5:40 PM, Otavio Salvador
<otavio at ossystems.com.br> wrote:
>
>
>
> On Fri, Nov 30, 2012 at 2:18 PM, Alex Gonzalez <alex at lindusembedded.com>
> wrote:
>>
>> Thanks Otavio,
>>
>> I changed the family overrides for machine overrrides as you suggested
>> and it is working now.
>
>
> Very good.
>
>>
>> One more thing, I was browsing at the meta-fsl-arm classes and I found
>> a possible unbound exception in fsl_bin_do_unpack.
>>
>> If fsl-eula is not present or False, save_cwd won't be set but it will
>> be used on the last line.
>>
>> I guess if fsl-eula always had to be true it wouldn't be an option, so
>> maybe the following patch or similar is acceptable:
>>
>> diff --git a/classes/fsl-eula-unpack.bbclass
>> b/classes/fsl-eula-unpack.bbclass
>> index 7a6a554..d4dbab8 100644
>> --- a/classes/fsl-eula-unpack.bbclass
>> +++ b/classes/fsl-eula-unpack.bbclass
>> @@ -7,6 +7,7 @@
>>  #  SRC_URI = "${FSL_MIRROR}/firmware-imx-${PV};fsl-eula=true"
>>
>>  python fsl_bin_do_unpack() {
>> +    save_cwd = os.getcwd()
>>      src_uri = (d.getVar('SRC_URI', True) or "").split()
>>      if len(src_uri) == 0:
>>          return
>
>
> Indeed; but I think the best fix would be to move the use of save_cwd to
> inside the for.
>
> Can you prepare an patch for it and give it a try?
>
>
> --
> Otavio Salvador                             O.S. Systems
> E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
> Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
>
>
> _______________________________________________
> meta-freescale mailing list
> meta-freescale at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/meta-freescale
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-fsl-eula-unpack-Avoid-unbound-exception.patch
Type: application/octet-stream
Size: 840 bytes
Desc: not available
URL: <http://lists.yoctoproject.org/pipermail/meta-freescale/attachments/20121203/32559882/attachment.obj>