[meta-amd] [meta-seattle][PATCH 0/2] BSP layer for AMD Seattle

[Adrian Calianu]

Hi Drew,

New changes looks ok. I see that common layer add dependency on meta-openembedded/meta-oe but that should not be a problem for Seattle BSP.
I have run a build and now we can use common layer also for Seattle BSP.
I will send a patch that mention (documentation file) about new dependency!

Thanks
Adrian

> -----Original Message-----
> From: Moseley, Drew [mailto:drew_moseley at mentor.com]
> Sent: Friday, January 29, 2016 9:36 PM
> To: Adrian Calianu <Adrian.Calianu at enea.com>
> Cc: meta-amd at yoctoproject.org
> Subject: Re: [meta-amd][meta-seattle][PATCH 0/2] BSP layer for AMD
> Seattle
> 
> Hi Adrian,
> 
> Thanks for pointing out the missing README files.  I’m sending a patch series
> that adds those and also that makes the core-image-* updates you
> suggested.  Please take a look and let me know if you think it will suffice for
> you to include the common layer.  And if there are other changes needed
> we’re happy to take any patches you want to send.
> 
> Drew
> 
> > On Jan 27, 2016, at 3:52 AM, Adrian Calianu <adrian.calianu at enea.com>
> wrote:
> >
> > Hi Drew,
> >
> > Yes, indeed for now meta-amd/common layer does not add any benefits
> for Seattle BSP. It looks that that layer is more multimedia specific with some
> other customizations(Mentor).
> > Since Seattle BSP now is very slim I though does not worth to depend on
> common layer. But ones we find common things it is a very good idea to use
> a common layer.
> >
> > I can add a note about using common layer but before that, at least recipes
> that affect images(common/recipes-core/images/core-image-
> base.bbappend, common/recipes-sato/images/core-image-sato.bbappend)
> must be updated.
> >
> > Since you are the maintainer of meta-amd please could you update the
> image recipes to append mesa-demos only for a more specific OVERRIDE
> option(radeon,...)? After that I can send an update to documentation to use
> common layer.
> >
> > Looks that ok for you?
> >
> > Trying to understand how AMD's BSP are built I found that README files
> > from BSP layers are missing ( meta-amd/README: "Please see the README
> > files contained in the individual BSP layers for BSP-specific
> > information.")
> >
> > Thanks,
> > Adrian
> >
> > -----Original Message-----
> > From: Moseley, Drew [mailto:drew_moseley at mentor.com]
> > Sent: Tuesday, January 26, 2016 9:52 PM
> > To: Adrian Calianu <Adrian.Calianu at enea.com>
> > Cc: meta-amd at yoctoproject.org
> > Subject: Re: [meta-amd][meta-seattle][PATCH 0/2] BSP layer for AMD
> > Seattle
> >
> >
> >> On Jan 25, 2016, at 3:41 AM, Adrian Calianu <adrian.calianu at enea.com>
> wrote:
> >>
> >> BSP layer for the AMD Opteron A1100-Series, first 64-bit ARM-based
> >> processor(ARMv8) of AMD, codenamed "Seattle".
> >>
> >> This layer is not dependend on any other layer from meta-amd but is
> >> depended on oe-core layer.
> >
> > Hello Adrian,
> >
> > Is there a reason you didn’t include the meta-amd/common layer in your
> development activities?  The whole point of that layer is to gather common
> components across all AMD platforms and I think any machine layers in meta-
> amd should be able to include it.  It looks like you don’t currently add any
> packages or components from that layer so it’s possible that you will not
> currently get any benefit from it but in the long run we want to make sure
> the common bits really are common.  It would not surprise me if some of the
> settings in there need to be conditionalized on certain platforms or
> refactored back into the machine layers but if that’s the case we should
> make the effort to fix it now rather than simply not including it in these
> platforms.
> >
> > Drew
> >