[linux-yocto] [yocto-2.2.1][PATCH] Revert "tty: serial: 8250: add CON_CONSDEV to flags"

Dengke Du dengke.du at windriver.com
Sun Feb 26 21:48:50 PST 2017

From: Herbert Xu <herbert at gondor.apana.org.au>

Upstream commit: 6741f551a0b26479de2532ffa43a366747e6dbf3

This commit needs to be reverted because it prevents people from
using the serial console as a secondary console with input being
directed to tty0.

IOW, if you boot with console=ttyS0 console=tty0 then all kernels
prior to this commit will produce output on both ttyS0 and tty0
but input will only be taken from tty0.  With this patch the serial
console will always be the primary console instead of tty0,
potentially preventing people from getting into their machines in
emergency situations.

Fixes: d03516df8375 ("tty: serial: 8250: add CON_CONSDEV to flags")
Signed-off-by: Herbert Xu <herbert at gondor.apana.org.au>
Cc: stable <stable at vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>

Upstream-Status: Backport
Signed-off-by: Dengke Du <dengke.du at windriver.com>
 drivers/tty/serial/8250/8250_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
index dcf43f6..fa823a5 100644
--- a/drivers/tty/serial/8250/8250_core.c
+++ b/drivers/tty/serial/8250/8250_core.c
@@ -675,7 +675,7 @@ static struct console univ8250_console = {
 	.device		= uart_console_device,
 	.setup		= univ8250_console_setup,
 	.match		= univ8250_console_match,
 	.index		= -1,
 	.data		= &serial8250_reg,

More information about the linux-yocto mailing list