[linux-yocto] [PATCH v2 00/12] ktype refactoring: move DEBUG_KERNEL, EXPERT and EMBEDDED

[Bruce Ashfield]

On 16-02-12 08:42 PM, California Sullivan wrote:
> Targetted for yocto-4.4 and master.
>
> Changes since last revision:
>
> *Renamed extended to developer*
> More descriptive name than extended.
>
> *Add DEBUG_PREEMPT to debug-kernel feature*
> This is an important debug feature that we should explicitly enable.
> Enabling CONFIG_DEBUG_MUTEXES was also proposed, but I decided to leave
> that out for now, as it is new functionality and I want to keep it as
> close as possible to previous functionality for this refactoring
> series.
>
> *Removed HID disabling patch*
> We had somebody run into a keyboard not working because the HIDs were
> not enabled. These will probably be enabled in base eventually.
>
> *Removed PROCESSOR_SELECT from intel-core2-32.cfg*
> Forgot this my first pass. Without EXPERT we don't get this option and
> the kernel_configcheck task gives us a warning.
>
> *Explicitly enable DEBUG_KERNEL in developer.cfg*
> I want it to be absolutely clear we get DEBUG_KERNEL, even when
> inheriting developer nocfg.
>
> *Updated commit messages
> Minor things like bsp -> BSP, as well as updates based on the above changes.

These all look good. I read the patches, before this summary, just to
make sure the commit messages were standalone and clear. So now I'll see
if asked anything that is answered here.

>
> This patch series refactors the ktypes so that base and standard ktypes
> do not enable EMBEDDED, EXPERT, or DEBUG_KERNEL. The reason this
> decision was made is because production platforms likely do not want
> DEBUG_KERNEL enabled, and EMBEDDED selects EXPERT which selects
> DEBUG_KERNEL.
>
> A new ktype called "developer" was also created. This ktype
> enables the options now missing from standard and base, making it easy
> to maintain the functionality of a BSP through simply swapping the ktype
> from standard to developer. The preempt-rt ktype is now based off of
> developer in order to maintain its functionality.
>
> The new standard ktype does not include EMBEDDED, EXPERT, or
> DEBUG_KERNEL. Without DEBUG_KERNEL it loses a number of debug features
> that are selected by default. Without EXPERT it gains RFKILL_INPUT and
> DEBUG_MEMORY_INIT, while losing VMSPLIT_3G. These are only available to
> configure with CONFIG_EXPERT=y and default to EXPERT or !EXPERT. Not
> selecting EMBEDDED has no apparent impacts.
>
> Some coordination is required for this change, as existing BSPs WILL be
> affected, and will either need to accept the changes in the standard
> ktype or move to the developer ktype.

Generally speaking, this looks good. A few minor tweaks have been
suggested, but I think with a quick v3, we can pull this in for testing.

Bruce

>
> California Sullivan (12):
>    features/debug: add debug-kernel feature
>    ktypes: add developer ktype
>    ktypes/base: Disable EMBEDDED and DEBUG_KERNEL
>    CONFIG_PROCESSOR_SELECT: do not enable
>    intel-common-drivers.scc: move profiling and latencytop to a new file
>    romley.scc remove profiling and latencytop features
>    bsp/intel-common: add intel-core* developer BSPs
>    preempt-rt.scc: inlcude developer ktype instead of standard
>    intel-common: add intel-developer-drivers.scc to preempt-rt BSPS
>    CONFIG_I2C_I801: set option to yes in intel-core* BSPs
>    bsp: add developer common-pc BSPs
>    bsp: remove profiling and latencytop from non-developer common-pc BSPs
>
>   bsp/common-pc-64/common-pc-64-developer.scc     | 17 +++++++++++++++++
>   bsp/common-pc-64/common-pc-64-standard.scc      |  2 --
>   bsp/common-pc/common-pc-developer.scc           | 17 +++++++++++++++++
>   bsp/common-pc/common-pc-standard.scc            |  2 --
>   bsp/haswell-wc/haswell-wc.cfg                   |  2 +-
>   bsp/intel-common/intel-common-drivers.scc       |  2 --
>   bsp/intel-common/intel-core2-32-developer.scc   | 14 ++++++++++++++
>   bsp/intel-common/intel-core2-32-preempt-rt.scc  |  1 +
>   bsp/intel-common/intel-core2-32.cfg             |  1 -
>   bsp/intel-common/intel-corei7-64-developer.scc  | 13 +++++++++++++
>   bsp/intel-common/intel-corei7-64-preempt-rt.scc |  1 +
>   bsp/intel-common/intel-developer-drivers.scc    |  3 +++
>   bsp/mohonpeak/mohonpeak.cfg                     |  2 +-
>   bsp/romley/romley.scc                           |  3 ---
>   cfg/amd.cfg                                     |  1 -
>   cfg/intel.cfg                                   |  2 --
>   features/debug/debug-kernel.cfg                 |  3 +++
>   features/debug/debug-kernel.scc                 |  6 ++++++
>   features/debug/printk.scc                       |  1 +
>   features/latencytop/latencytop.scc              |  3 +++
>   features/profiling/profiling.scc                |  2 ++
>   features/soc/baytrail/baytrail.cfg              |  2 +-
>   ktypes/base/base.cfg                            |  6 +++---
>   ktypes/developer/developer.cfg                  | 19 +++++++++++++++++++
>   ktypes/developer/developer.scc                  | 10 ++++++++++
>   ktypes/preempt-rt/preempt-rt.scc                |  2 +-
>   26 files changed, 117 insertions(+), 20 deletions(-)
>   create mode 100644 bsp/common-pc-64/common-pc-64-developer.scc
>   create mode 100644 bsp/common-pc/common-pc-developer.scc
>   create mode 100644 bsp/intel-common/intel-core2-32-developer.scc
>   create mode 100644 bsp/intel-common/intel-corei7-64-developer.scc
>   create mode 100644 bsp/intel-common/intel-developer-drivers.scc
>   create mode 100644 features/debug/debug-kernel.cfg
>   create mode 100644 features/debug/debug-kernel.scc
>   create mode 100644 ktypes/developer/developer.cfg
>   create mode 100644 ktypes/developer/developer.scc
>