[linux-yocto] [PATCH v2 00/12] features/debug: add debug-kernel feature

[Bruce Ashfield]

On 16-02-12 08:42 PM, California Sullivan wrote:
> Since EMBEDDED, EXPERT, and DEBUG_KERNEL are being removed from the base
> ktype, we can no longer assume DEBUG_KERNEL is enabled.
>
> Also add this fragment to features that require DEBUG_KERNEL.
>
> Signed-off-by: California Sullivan <california.l.sullivan at intel.com>
> ---
>   features/debug/debug-kernel.cfg    | 3 +++
>   features/debug/debug-kernel.scc    | 6 ++++++
>   features/debug/printk.scc          | 1 +
>   features/latencytop/latencytop.scc | 3 +++
>   features/profiling/profiling.scc   | 2 ++
>   5 files changed, 15 insertions(+)
>   create mode 100644 features/debug/debug-kernel.cfg
>   create mode 100644 features/debug/debug-kernel.scc
>
> diff --git a/features/debug/debug-kernel.cfg b/features/debug/debug-kernel.cfg
> new file mode 100644
> index 0000000..cdc07a9
> --- /dev/null
> +++ b/features/debug/debug-kernel.cfg
> @@ -0,0 +1,3 @@
> +CONFIG_DEBUG_KERNEL=y
> +CONFIG_DEBUG_INFO=y
> +CONFIG_DEBUG_PREEMPT=y
> diff --git a/features/debug/debug-kernel.scc b/features/debug/debug-kernel.scc
> new file mode 100644
> index 0000000..d3325cb
> --- /dev/null
> +++ b/features/debug/debug-kernel.scc
> @@ -0,0 +1,6 @@
> +
> +define KFEATURE_DESCRIPTION "Enable debug kernel and some important debug features"
> +define KFEATURE_COMPATIBILITY all
> +
> +kconf non-hardware debug-kernel.cfg
> +
> diff --git a/features/debug/printk.scc b/features/debug/printk.scc
> index d592605..3526dea 100644
> --- a/features/debug/printk.scc
> +++ b/features/debug/printk.scc
> @@ -8,3 +8,4 @@ define KFEATURE_COMPATIBILITY all
>
>   kconf non-hardware printk.cfg
>
> +include debug-kernel.scc
> diff --git a/features/latencytop/latencytop.scc b/features/latencytop/latencytop.scc
> index 923b5d9..af59e24 100644
> --- a/features/latencytop/latencytop.scc
> +++ b/features/latencytop/latencytop.scc
> @@ -1,4 +1,7 @@
> +

Minor 'nit, looks like we are adding a blank line.

Bruce

>   define KFEATURE_DESCRIPTION "Enable latencytop"
>   define KFEATURE_COMPATIBILITY arch
>
>   kconf non-hardware latencytop.cfg
> +
> +include features/debug/debug-kernel.scc
> diff --git a/features/profiling/profiling.scc b/features/profiling/profiling.scc
> index 32032fa..50cdcfc 100644
> --- a/features/profiling/profiling.scc
> +++ b/features/profiling/profiling.scc
> @@ -2,3 +2,5 @@ define KFEATURE_DESCRIPTION "Enable profiling and timerstats"
>   define KFEATURE_COMPATIBILITY board
>
>   kconf non-hardware profiling.cfg
> +
> +include features/debug/debug-kernel.scc
>