[linux-yocto] [PATCH 4/7] spi-pxa2xx: fixed ACPI-based enumeration of SPI devices.

Bruce Ashfield bruce.ashfield at windriver.com
Wed Feb 17 08:21:23 PST 2016


On 16-02-16 05:01 PM, Saul Wold wrote:
> From: Ismo Puustinen <ismo.puustinen at intel.com>
>
> Slave devices were not enumerated by ACPI data because the ACPI handle
> for the spi-pxa2xx controller was NULL if it was itself enumerated by
> PCI.
>
> Upstream-status: Inappropriate, real fix forthcoming

This of course leaves us wondering what the "real fix" is, and if there
are any drawbacks to this one. Maybe something less ominous for the
upstream status ? Like "re-worked version pending".

Bruce

>
> Signed-off-by: Ismo Puustinen <ismo.puustinen at intel.com>
> ---
>   drivers/spi/spi-pxa2xx-pci.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-pxa2xx-pci.c b/drivers/spi/spi-pxa2xx-pci.c
> index fa7399e..c5a7111 100644
> --- a/drivers/spi/spi-pxa2xx-pci.c
> +++ b/drivers/spi/spi-pxa2xx-pci.c
> @@ -170,6 +170,7 @@ static int pxa2xx_spi_pci_probe(struct pci_dev *dev,
>   	memset(&pi, 0, sizeof(pi));
>   	pi.parent = &dev->dev;
>   	pi.name = "pxa2xx-spi";
> +	pi.fwnode = dev->dev.fwnode;
>   	pi.id = ssp->port_id;
>   	pi.data = &spi_pdata;
>   	pi.size_data = sizeof(spi_pdata);
>



More information about the linux-yocto mailing list