[linux-yocto] [PATCH 07/29] i2c: core: only use set_scl for bus recovery after calling prepare_recovery

Saul Wold sgw at linux.intel.com
Fri Feb 5 06:53:24 PST 2016


From: Jan Luebbe <jlu at pengutronix.de>

Using set_scl may be ineffective before calling the driver specific
prepare_recovery callback, which might change into a test mode. So
instead of setting SCL in i2c_generic_scl_recovery, move it to
i2c_generic_recovery (after the optional prepare_recovery).

Signed-off-by: Jan Luebbe <jlu at pengutronix.de>
Acked-by: Alexander Sverdlin <alexander.sverdlin at nokia.com>
Tested-by: Alexander Sverdlin <alexander.sverdlin at gmail.com>
Signed-off-by: Wolfram Sang <wsa at the-dreams.de>

Upstream-status: Backport
Signed-off-by: Saul Wold <sgw at linux.intel.com>
---
 drivers/i2c/i2c-core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/i2c/i2c-core.c b/drivers/i2c/i2c-core.c
index 069a41f..be992b3 100644
--- a/drivers/i2c/i2c-core.c
+++ b/drivers/i2c/i2c-core.c
@@ -567,6 +567,9 @@ static int i2c_generic_recovery(struct i2c_adapter *adap)
 	if (bri->prepare_recovery)
 		bri->prepare_recovery(adap);
 
+	bri->set_scl(adap, val);
+	ndelay(RECOVERY_NDELAY);
+
 	/*
 	 * By this time SCL is high, as we need to give 9 falling-rising edges
 	 */
@@ -597,7 +600,6 @@ static int i2c_generic_recovery(struct i2c_adapter *adap)
 
 int i2c_generic_scl_recovery(struct i2c_adapter *adap)
 {
-	adap->bus_recovery_info->set_scl(adap, 1);
 	return i2c_generic_recovery(adap);
 }
 EXPORT_SYMBOL_GPL(i2c_generic_scl_recovery);
-- 
2.5.0



More information about the linux-yocto mailing list