[linux-yocto] [PATCH 30/30] ARM: 7670/1: fix the memset fix

Bruce Ashfield bruce.ashfield at windriver.com
Thu May 1 19:23:41 PDT 2014


On 2014-05-01, 9:11 PM, Nicolas Pitre wrote:
> On Thu, 1 May 2014, Greg Kroah-Hartman wrote:
>
>> On Thu, May 01, 2014 at 08:29:52AM -0700, Charlie Paul wrote:
>>> From: Nicolas Pitre <nicolas.pitre at linaro.org>
>>>
>>> commit 418df63adac56841ef6b0f1fcf435bc64d4ed177 upstream.
>>>
>>> Commit 455bd4c430b0 ("ARM: 7668/1: fix memset-related crashes caused by
>>> recent GCC (4.7.2) optimizations") attempted to fix a compliance issue
>>> with the memset return value.  However the memset itself became broken
>>> by that patch for misaligned pointers.
>>>
>>> This fixes the above by branching over the entry code from the
>>> misaligned fixup code to avoid reloading the original pointer.
>>>
>>> Also, because the function entry alignment is wrong in the Thumb mode
>>> compilation, that fixup code is moved to the end.
>>>
>>> While at it, the entry instructions are slightly reworked to help dual
>>> issue pipelines.
>>>
>>> Signed-off-by: Nicolas Pitre <nico at linaro.org>
>>> Tested-by: Alexander Holler <holler at ahsoftware.de>
>>> Signed-off-by: Russell King <rmk+kernel at arm.linux.org.uk>
>>> Cc: Eric Bénard <eric at eukrea.com>
>>> Signed-off-by: Greg Kroah-Hartman <gregkh at linuxfoundation.org>
>>> ---
>>>   arch/arm/lib/memset.S |   22 +++-------------------
>>>   1 file changed, 3 insertions(+), 19 deletions(-)
>>
>> What is this patch for, and why send it to me?
>
> No idea.  You did apply it to the stable trees you maintain quite a
> while a go already.

Indeed.

Looks like another lesson learned about git suppress-cc when porting
and sending patches.

This should be for the 3.4 yocto kernel tree, which also already has
these changes via -stable. So the broadcast wasn't even necessary.

Anyway, sorry for the noise, and I'll sort this out (and get out of
your inboxes).

Bruce

>
>
> Nicolas
>



More information about the linux-yocto mailing list