[linux-yocto] [PATCH 4/4] intel-common: Add intel-common BSPs

Thu Feb 6 06:27:17 PST 2014

On Wed, Feb 5, 2014 at 7:37 PM, Darren Hart <dvhart at linux.intel.com> wrote:
> Create the intel-core2-32 and intel-corei7-64 BSP descriptions. These
> BSPs include all the core support for the other Intel BSPs in the
> repository by including the corresponding BSP scc file.
>
> This is an initial step to get the machines available and testing.
> Further refactoring is expected to take place to reduce duplication and
> ultimately obviate the need for many of the other BSP descriptions, at
> least the -standard versions which should be adequately covered by these
> generic versions.
>
> Signed-off-by: Darren Hart <dvhart at linux.intel.com>
> ---
>  .../bsp/intel-common/intel-common-standard.scc     |    7 +++++
>  .../kernel-cache/bsp/intel-common/intel-common.scc |   30 ++++++++++++++++++++
>  .../bsp/intel-common/intel-core2-32-standard.scc   |    9 ++++++
>  .../bsp/intel-common/intel-core2-32.scc            |   10 +++++++
>  .../bsp/intel-common/intel-corei7-64-standard.scc  |    9 ++++++
>  .../bsp/intel-common/intel-corei7-64.scc           |   12 ++++++++
>  6 files changed, 77 insertions(+)
>  create mode 100644 meta/cfg/kernel-cache/bsp/intel-common/intel-common-standard.scc
>  create mode 100644 meta/cfg/kernel-cache/bsp/intel-common/intel-common.scc
>  create mode 100644 meta/cfg/kernel-cache/bsp/intel-common/intel-core2-32-standard.scc
>  create mode 100644 meta/cfg/kernel-cache/bsp/intel-common/intel-core2-32.cfg
>  create mode 100644 meta/cfg/kernel-cache/bsp/intel-common/intel-core2-32.scc
>  create mode 100644 meta/cfg/kernel-cache/bsp/intel-common/intel-corei7-64-standard.scc
>  create mode 100644 meta/cfg/kernel-cache/bsp/intel-common/intel-corei7-64.cfg
>  create mode 100644 meta/cfg/kernel-cache/bsp/intel-common/intel-corei7-64.scc
>
> diff --git a/meta/cfg/kernel-cache/bsp/intel-common/intel-common-standard.scc b/meta/cfg/kernel-cache/bsp/intel-common/intel-common-standard.scc
> new file mode 100644
> index 0000000..509f32e
> --- /dev/null
> +++ b/meta/cfg/kernel-cache/bsp/intel-common/intel-common-standard.scc
> @@ -0,0 +1,7 @@
> +include ktypes/standard/standard.scc
> +
> +# default policy for standard kernels
> +include cfg/usb-mass-storage.scc
> +include cfg/boot-live.scc
> +include features/latencytop/latencytop.scc
> +include features/profiling/profiling.scc
> diff --git a/meta/cfg/kernel-cache/bsp/intel-common/intel-common.scc b/meta/cfg/kernel-cache/bsp/intel-common/intel-common.scc
> new file mode 100644
> index 0000000..8e3e06f
> --- /dev/null
> +++ b/meta/cfg/kernel-cache/bsp/intel-common/intel-common.scc
> @@ -0,0 +1,30 @@
> +include cfg/efi.scc
> +
> +include cfg/dmaengine.scc
> +include features/usb/usb-gadgets.scc
> +include features/usb/touchscreen-composite.scc
> +include cfg/vesafb.scc
> +include features/uio/uio.scc
> +
> +# Common devices
> +# Earlyprintk and port debug requires 8250
> +kconf hardware cfg/8250.scc
> +include features/usb/ehci-hcd.scc
> +include features/usb/ohci-hcd.scc
> +include features/usb/xhci-hcd.scc
> +include cfg/timer/hpet.scc
> +include cfg/timer/rtc.scc
> +include features/eg20t/eg20t.scc
> +include features/i915/i915.scc
> +include features/igb/igb.scc
> +include features/ixgbe/ixgbe.scc
> +
> +# Intel technology
> +include features/amt/mei/mei.scc
> +include features/power/intel.scc
> +
> +# Subsystems and interfaces
> +include features/hugetlb/hugetlb.scc
> +include features/i2c/i2cdev.scc
> +include features/leds/leds.scc
> +include features/spi/spidev.scc
> diff --git a/meta/cfg/kernel-cache/bsp/intel-common/intel-core2-32-standard.scc b/meta/cfg/kernel-cache/bsp/intel-common/intel-core2-32-standard.scc
> new file mode 100644
> index 0000000..89ee64a
> --- /dev/null
> +++ b/meta/cfg/kernel-cache/bsp/intel-common/intel-core2-32-standard.scc
> @@ -0,0 +1,9 @@
> +define KMACHINE intel-core2-32
> +define KARCH i386
> +define KTYPE standard
> +
> +include intel-core2-32.scc
> +include intel-common-standard.scc
> +
> +# Pile of common drivers for the standard ktype
> +include bsp/common-pc/common-pc-standard.scc

You'd be wise to include this first, and then your new core2 and
common fragments,
since the last option through the gate wins, a change to common-pc
will have more
impact than a change to your new fragments.

A second comment on this, any opinion on renaming .. or just
continuing on with the
"common-pc" branch naming ? By including this fragment we are following the
standard/common-pc naming convention that has been around for 5+ years now.
I've never really come up with a better name, but I thought I'd throw
that thought out.

> diff --git a/meta/cfg/kernel-cache/bsp/intel-common/intel-core2-32.cfg b/meta/cfg/kernel-cache/bsp/intel-common/intel-core2-32.cfg
> new file mode 100644
> index 0000000..e69de29
> diff --git a/meta/cfg/kernel-cache/bsp/intel-common/intel-core2-32.scc b/meta/cfg/kernel-cache/bsp/intel-common/intel-core2-32.scc
> new file mode 100644
> index 0000000..63eb58a
> --- /dev/null
> +++ b/meta/cfg/kernel-cache/bsp/intel-common/intel-core2-32.scc
> @@ -0,0 +1,10 @@
> +include cfg/x86.scc
> +
> +include intel-common.scc
> +kconf hardware intel-core2-32.cfg
> +
> +# Supported platforms
> +include bsp/crownbay/crownbay.scc
> +include bsp/emenlow/emenlow.scc
> +include bsp/fri2/fri2.scc
> +include bsp/sys940x/sys940x.scc
> diff --git a/meta/cfg/kernel-cache/bsp/intel-common/intel-corei7-64-standard.scc b/meta/cfg/kernel-cache/bsp/intel-common/intel-corei7-64-standard.scc
> new file mode 100644
> index 0000000..aba304f
> --- /dev/null
> +++ b/meta/cfg/kernel-cache/bsp/intel-common/intel-corei7-64-standard.scc
> @@ -0,0 +1,9 @@
> +define KMACHINE intel-corei7-64
> +define KARCH x86_64
> +define KTYPE standard
> +
> +include intel-corei7-64.scc
> +include intel-common-standard.scc
> +
> +# Pile of common drivers for the standard ktype
> +include bsp/common-pc-64/common-pc-64-standard.scc

Same comments as I had with the 32 bit variant.

But other than this, the entire series looks fine to me.

Bruce

> diff --git a/meta/cfg/kernel-cache/bsp/intel-common/intel-corei7-64.cfg b/meta/cfg/kernel-cache/bsp/intel-common/intel-corei7-64.cfg
> new file mode 100644
> index 0000000..e69de29
> diff --git a/meta/cfg/kernel-cache/bsp/intel-common/intel-corei7-64.scc b/meta/cfg/kernel-cache/bsp/intel-common/intel-corei7-64.scc
> new file mode 100644
> index 0000000..964408e
> --- /dev/null
> +++ b/meta/cfg/kernel-cache/bsp/intel-common/intel-corei7-64.scc
> @@ -0,0 +1,12 @@
> +include cfg/x86_64.scc
> +
> +include intel-common.scc
> +kconf hardware intel-corei7-64.cfg
> +
> +# Supported platforms
> +include bsp/chiefriver/chiefriver.scc
> +include bsp/crystalforest/crystalforest.scc
> +include bsp/haswell-wc/haswell-wc.scc
> +include bsp/jasperforest/jasperforest.scc
> +include bsp/romley/romley.scc
> +include bsp/sugarbay/sugarbay.scc
> --
> 1.7.9.5
>
> _______________________________________________
> linux-yocto mailing list
> linux-yocto at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/linux-yocto

-- 
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"