[linux-yocto] [PATCH 03/16] remove old MEDIA config fragments

[Darren Hart]

On Fri, 2013-11-22 at 21:35 +0000, Kamble, Nitin A wrote:
> 
> > -----Original Message-----
> > From: Darren Hart [mailto:dvhart at linux.intel.com]
> > Sent: Friday, November 22, 2013 12:53 PM
> > To: Kamble, Nitin A
> > Cc: linux-yocto at yoctoproject.org; bruce.ashfield at windriver.com
> > Subject: Re: [PATCH 03/16] remove old MEDIA config fragments
> > 
> > On Fri, 2013-11-22 at 11:35 -0800, nitin.a.kamble at intel.com wrote:
> > > From: Nitin A Kamble <nitin.a.kamble at intel.com>
> > >
> > > These are getting replaced with newer extensive MEDIA config fragments.
> > >
> > 
> > OK, but this should come last, after the others are in place and used by the
> > BSPs.
> > 
> The commit can be shifted easily. As you can guess, I was not concerned about
> for couple of reasons. The pull request bunches all the concerned commits together. 
> And BSPs would not get affected unless one intends to break, by setting random commit
> IDs without testing. 
>   Anyway it is a quick fix so I won't argue.

This is actually an important point. You cannot consider your pull
request to be atomic. Patches must apply in order and build at each
patch. Without this, we break the ability to bisect the tree to identify
problems.

Many developers will run their series through build scripts which ensure
successful builds after each commit before proposing the series for
inclusion. That's admittedly overkill here, but it illustrates the
point.

--
Darren

> Nitin
> 
> 
> > --
> > Darren
> > 
> > > Signed-off-by: Nitin A Kamble <nitin.a.kamble at intel.com>
> > > ---
> > >  .../kernel-cache/features/media/media-camera.cfg    |  4 ----
> > >  .../kernel-cache/features/media/media-camera.scc    |  4 ----
> > >  meta/cfg/kernel-cache/features/media/v4l2.cfg       | 21 ---------------------
> > >  meta/cfg/kernel-cache/features/media/v4l2.scc       |  6 ------
> > >  meta/cfg/kernel-cache/features/usb/usb-uvcvideo.cfg |  3 ---
> > > meta/cfg/kernel-cache/features/usb/usb-uvcvideo.scc |  7 -------
> > >  6 files changed, 45 deletions(-)
> > >  delete mode 100644
> > > meta/cfg/kernel-cache/features/media/media-camera.cfg
> > >  delete mode 100644
> > > meta/cfg/kernel-cache/features/media/media-camera.scc
> > >  delete mode 100644 meta/cfg/kernel-cache/features/media/v4l2.cfg
> > >  delete mode 100644 meta/cfg/kernel-cache/features/media/v4l2.scc
> > >  delete mode 100644
> > > meta/cfg/kernel-cache/features/usb/usb-uvcvideo.cfg
> > >  delete mode 100644
> > > meta/cfg/kernel-cache/features/usb/usb-uvcvideo.scc
> > >
> > > diff --git a/meta/cfg/kernel-cache/features/media/media-camera.cfg
> > > b/meta/cfg/kernel-cache/features/media/media-camera.cfg
> > > deleted file mode 100644
> > > index 6e173a9..0000000
> > > --- a/meta/cfg/kernel-cache/features/media/media-camera.cfg
> > > +++ /dev/null
> > > @@ -1,4 +0,0 @@
> > > -# Enable Multimedia and Camera Device support -
> > CONFIG_MEDIA_SUPPORT=m
> > > -CONFIG_MEDIA_CAMERA_SUPPORT=y -
> > CONFIG_MEDIA_SUBDRV_AUTOSELECT=y diff
> > > --git a/meta/cfg/kernel-cache/features/media/media-camera.scc
> > > b/meta/cfg/kernel-cache/features/media/media-camera.scc
> > > deleted file mode 100644
> > > index 15d04e4..0000000
> > > --- a/meta/cfg/kernel-cache/features/media/media-camera.scc
> > > +++ /dev/null
> > > @@ -1,4 +0,0 @@
> > > -define KFEATURE_DESCRIPTION "Enable camera media device as a
> > module"
> > > -define KFEATURE_COMPATIBILITY all
> > > -
> > > -kconf non-hardware media-camera.cfg
> > > diff --git a/meta/cfg/kernel-cache/features/media/v4l2.cfg
> > > b/meta/cfg/kernel-cache/features/media/v4l2.cfg
> > > deleted file mode 100644
> > > index 614886c..0000000
> > > --- a/meta/cfg/kernel-cache/features/media/v4l2.cfg
> > > +++ /dev/null
> > > @@ -1,21 +0,0 @@
> > > -# Enable the V4L2 core and API
> > > -CONFIG_VIDEO_DEV=m
> > > -CONFIG_VIDEO_V4L2=m
> > > -VIDEO_V4L2_SUBDEV_API=y
> > > -
> > > -# Used by drivers that need v4l2-mem2mem.ko -
> > V4L2_MEM2MEM_DEV=m
> > > -
> > > -# Used by drivers that need Videobuf modules -VIDEOBUF_GEN=m
> > > -VIDEOBUF_DMA_SG=m -VIDEOBUF_VMALLOC=m -
> > VIDEOBUF_DMA_CONTIG=m
> > > -VIDEOBUF_DVB=m
> > > -
> > > -# Used by drivers that need Videobuf2 modules
> > > -CONFIG_VIDEOBUF2_CORE=m -CONFIG_VIDEOBUF2_MEMOPS=m
> > > -CONFIG_VIDEOBUF2_VMALLOC=m -VIDEOBUF2_DMA_CONTIG=m
> > > -VIDEOBUF2_DMA_SG=m diff --git
> > > a/meta/cfg/kernel-cache/features/media/v4l2.scc
> > > b/meta/cfg/kernel-cache/features/media/v4l2.scc
> > > deleted file mode 100644
> > > index 09ab7d6..0000000
> > > --- a/meta/cfg/kernel-cache/features/media/v4l2.scc
> > > +++ /dev/null
> > > @@ -1,6 +0,0 @@
> > > -define KFEATURE_DESCRIPTION "Enable Video for Linux 2 as a module"
> > > -define KFEATURE_COMPATIBILITY all
> > > -
> > > -include media-camera.scc
> > > -
> > > -kconf non-hardware v4l2.cfg
> > > diff --git a/meta/cfg/kernel-cache/features/usb/usb-uvcvideo.cfg
> > > b/meta/cfg/kernel-cache/features/usb/usb-uvcvideo.cfg
> > > deleted file mode 100644
> > > index 366f08b..0000000
> > > --- a/meta/cfg/kernel-cache/features/usb/usb-uvcvideo.cfg
> > > +++ /dev/null
> > > @@ -1,3 +0,0 @@
> > > -# Enable USB Video Class camera support -
> > CONFIG_MEDIA_USB_SUPPORT=y
> > > -CONFIG_USB_VIDEO_CLASS=m diff --git
> > > a/meta/cfg/kernel-cache/features/usb/usb-uvcvideo.scc
> > > b/meta/cfg/kernel-cache/features/usb/usb-uvcvideo.scc
> > > deleted file mode 100644
> > > index a8cd0f1..0000000
> > > --- a/meta/cfg/kernel-cache/features/usb/usb-uvcvideo.scc
> > > +++ /dev/null
> > > @@ -1,7 +0,0 @@
> > > -define KFEATURE_DESCRIPTION "Enable USB UVC Video Camera Module"
> > > -define KFEATURE_COMPATIBILITY board
> > > -
> > > -include usb-base.scc
> > > -include features/media/media-camera.scc
> > > -
> > > -kconf hardware usb-uvcvideo.cfg
> > 
> > --
> > Darren Hart
> > Intel Open Source Technology Center
> > Yocto Project - Linux Kernel
> > 
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel