[linux-yocto] [PATCH 01/16] minnow.cfg: Enable TEA575X sound driver

[Darren Hart]

On Fri, 2013-11-22 at 21:26 +0000, Kamble, Nitin A wrote:
> 
> > -----Original Message-----
> > From: Darren Hart [mailto:dvhart at linux.intel.com]
> > Sent: Friday, November 22, 2013 12:50 PM
> > To: Kamble, Nitin A
> > Cc: linux-yocto at yoctoproject.org; bruce.ashfield at windriver.com
> > Subject: Re: [PATCH 01/16] minnow.cfg: Enable TEA575X sound driver
> > 
> > On Fri, 2013-11-22 at 11:35 -0800, nitin.a.kamble at intel.com wrote:
> > > From: Nitin A Kamble <nitin.a.kamble at intel.com>
> > >
> > > The TEA575X sound driver configuration is relocated from the kernel
> > > recipe's media.cfg to here.
> > 
> > This isn't required for the minnowboard, it uses an HDA. This should be part
> > of a more generic sound fragment that can be included by BSPs like
> > genericx86*.
> 
> The only reason for adding this was, because minnow board used it in
> it's media.cfg. If it is not needed for minnow, then why to keep it?

This fragment was used in Minnow to allow for general expansion. It
should only be added explicitly to a BSP fragment if it is always part
of that BSP.

This device should be part of a general sound fragment that the BSP can
choose to include, and other BSPs can make use of.

--
Darren

> 
> Nitin
> 
> 
> 
> > 
> > --
> > Darren
> > 
> > >
> > > Signed-off-by: Nitin A Kamble <nitin.a.kamble at intel.com>
> > > ---
> > >  meta/cfg/kernel-cache/bsp/minnow/minnow.cfg | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/meta/cfg/kernel-cache/bsp/minnow/minnow.cfg
> > > b/meta/cfg/kernel-cache/bsp/minnow/minnow.cfg
> > > index 2be4ea4..b08f411 100644
> > > --- a/meta/cfg/kernel-cache/bsp/minnow/minnow.cfg
> > > +++ b/meta/cfg/kernel-cache/bsp/minnow/minnow.cfg
> > > @@ -8,6 +8,7 @@ CONFIG_MTRR=y
> > >  # Basic hardware support for the box - network, USB, PCI, sound
> > > CONFIG_PCI=y  CONFIG_PCIEPORTBUS=y
> > > +CONFIG_SND_TEA575X=m
> > >
> > >  # Ensure we can boot over MMC
> > >  CONFIG_MMC=y
> > 
> > --
> > Darren Hart
> > Intel Open Source Technology Center
> > Yocto Project - Linux Kernel
> > 
> 

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel