[linux-yocto] [PATCH 06/16] media/usb: A feature for USB media devices.

[Darren Hart]

On Fri, 2013-11-22 at 11:35 -0800, nitin.a.kamble at intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble at intel.com>
> 
> This enables various USB media devices. Many of the USB webcams
> drivers are enabled here.

OK, you also have usb_tv, so probably want to be a bit more specific
about the name here, what exactly does this fragment support? This makes
it clear to people looking to use it, but also helps in the future when
we add things to know where they should go.

> 
> Signed-off-by: Nitin A Kamble <nitin.a.kamble at intel.com>
> ---
>  meta/cfg/kernel-cache/features/media/usb.cfg | 76 ++++++++++++++++++++++++++++
>  meta/cfg/kernel-cache/features/media/usb.scc |  7 +++
>  2 files changed, 83 insertions(+)
>  create mode 100644 meta/cfg/kernel-cache/features/media/usb.cfg
>  create mode 100644 meta/cfg/kernel-cache/features/media/usb.scc
> 
> diff --git a/meta/cfg/kernel-cache/features/media/usb.cfg b/meta/cfg/kernel-cache/features/media/usb.cfg
> new file mode 100644
> index 0000000..12ac598
> --- /dev/null
> +++ b/meta/cfg/kernel-cache/features/media/usb.cfg
> @@ -0,0 +1,76 @@
> +# Support For USB Media Adapters/devices
> +CONFIG_MEDIA_USB_SUPPORT=y
> +
> +# USB Video Class Webcam Drivers
> +CONFIG_USB_VIDEO_CLASS=m
> +CONFIG_USB_VIDEO_CLASS_INPUT_EVDEV=y
> +
> +# USB GSPCA Webcam Drivers
> +CONFIG_USB_GSPCA=m
> +CONFIG_USB_M5602=m
> +CONFIG_USB_STV06XX=m
> +CONFIG_USB_GL860=m
> +CONFIG_USB_GSPCA_BENQ=m
> +CONFIG_USB_GSPCA_CONEX=m
> +CONFIG_USB_GSPCA_CPIA1=m
> +CONFIG_USB_GSPCA_ETOMS=m
> +CONFIG_USB_GSPCA_FINEPIX=m
> +CONFIG_USB_GSPCA_JEILINJ=m
> +CONFIG_USB_GSPCA_JL2005BCD=m
> +CONFIG_USB_GSPCA_KINECT=m
> +CONFIG_USB_GSPCA_KONICA=m
> +CONFIG_USB_GSPCA_MARS=m
> +CONFIG_USB_GSPCA_MR97310A=m
> +CONFIG_USB_GSPCA_NW80X=m
> +CONFIG_USB_GSPCA_OV519=m
> +CONFIG_USB_GSPCA_OV534=m
> +CONFIG_USB_GSPCA_OV534_9=m
> +CONFIG_USB_GSPCA_PAC207=m
> +CONFIG_USB_GSPCA_PAC7302=m
> +CONFIG_USB_GSPCA_PAC7311=m
> +CONFIG_USB_GSPCA_SE401=m
> +CONFIG_USB_GSPCA_SN9C2028=m
> +CONFIG_USB_GSPCA_SN9C20X=m
> +CONFIG_USB_GSPCA_SONIXB=m
> +CONFIG_USB_GSPCA_SONIXJ=m
> +CONFIG_USB_GSPCA_SPCA500=m
> +CONFIG_USB_GSPCA_SPCA501=m
> +CONFIG_USB_GSPCA_SPCA505=m
> +CONFIG_USB_GSPCA_SPCA506=m
> +CONFIG_USB_GSPCA_SPCA508=m
> +CONFIG_USB_GSPCA_SPCA561=m
> +CONFIG_USB_GSPCA_SPCA1528=m
> +CONFIG_USB_GSPCA_SQ905=m
> +CONFIG_USB_GSPCA_SQ905C=m
> +CONFIG_USB_GSPCA_SQ930X=m
> +CONFIG_USB_GSPCA_STK014=m
> +CONFIG_USB_GSPCA_STV0680=m
> +CONFIG_USB_GSPCA_SUNPLUS=m
> +CONFIG_USB_GSPCA_T613=m
> +CONFIG_USB_GSPCA_TOPRO=m
> +CONFIG_USB_GSPCA_TV8532=m
> +CONFIG_USB_GSPCA_VC032X=m
> +CONFIG_USB_GSPCA_VICAM=m
> +CONFIG_USB_GSPCA_XIRLINK_CIT=m
> +CONFIG_USB_GSPCA_ZC3XX=m
> +
> +# USB Philips Camera Drivers
> +CONFIG_USB_PWC=m
> +# CONFIG_USB_PWC_DEBUG is not set

Off by default, no need to disable explicitly.

> +CONFIG_USB_PWC_INPUT_EVDEV=y

Defaults to yes, also not really needed - but I'm not terribly picky
about this. It's selectable, so I could go either way.

> +
> +# Vision's CPiA2 (Colour Processor Interface ASIC) Camera Drivers
> +CONFIG_VIDEO_CPIA2=m
> +
> +# CONFIG_USB_ZR364XX is not set

Why?

> +
> +# USB Syntek DC1125 Camera Support
> +CONFIG_USB_STKWEBCAM=m
> +
> +# USB Sensoray 2255 video capture Device
> +CONFIG_USB_S2255=m
> +
> +# USB SN9C1xx PC Camera Controller Support
> +CONFIG_USB_SN9C102=m
> +
> +# CONFIG_USB_G_WEBCAM is not set

I can see not enabling this here, better off in a usb-gadgets
fragment... but why disable it explicitly?

> diff --git a/meta/cfg/kernel-cache/features/media/usb.scc b/meta/cfg/kernel-cache/features/media/usb.scc
> new file mode 100644
> index 0000000..5602311
> --- /dev/null
> +++ b/meta/cfg/kernel-cache/features/media/usb.scc
> @@ -0,0 +1,7 @@
> +define KFEATURE_DESCRIPTION "Enable Configuration For USB Media Adapters"
> +define KFEATURE_COMPATIBILITY all
> +
> +include media.scc

Good, grabbed the dependencies from there.

> +include ../usb/usb-base.cfg

I'd list this first though just to keep the dependency chain a bit more
obvious.

> +
> +kconf hardware usb.cfg

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel