[linux-yocto] [PATCH 02/16] firmware.scc/cfg : Feature for firmware loading

[Bruce Ashfield]

On 13-11-22 03:51 PM, Hart, Darren wrote:
> On Fri, 2013-11-22 at 11:35 -0800, nitin.a.kamble at intel.com wrote:
>> From: Nitin A Kamble <nitin.a.kamble at intel.com>
>>
>> This enables the kernel configuration for firmware loading.
>
> This is bare-minimum in size (3 CONFIGs) in my opinion to be considered
> for it's own fragment. I'm OK with it - but I wonder, Bruce, would this
> be better off just included in the base.cfg? It seems a reasonable thing
> to just include by default on all linux-yocto kernels.

It is fairly common, outside of the CONFIG_ALTERA_STAPL=m, which
is hiding at the bottom.

Rather than the base (which is harder to turn off), I'd say the
standard.scc would be better, since tiny and preempt-rt can more
easily not have the fragment enabled.

Bruce


>
> --
> Darren
>
>>
>> Signed-off-by: Nitin A Kamble <nitin.a.kamble at intel.com>
>> ---
>>   meta/cfg/kernel-cache/features/firmware/firmware.cfg | 8 ++++++++
>>   meta/cfg/kernel-cache/features/firmware/firmware.scc | 4 ++++
>>   2 files changed, 12 insertions(+)
>>   create mode 100644 meta/cfg/kernel-cache/features/firmware/firmware.cfg
>>   create mode 100644 meta/cfg/kernel-cache/features/firmware/firmware.scc
>>
>> diff --git a/meta/cfg/kernel-cache/features/firmware/firmware.cfg b/meta/cfg/kernel-cache/features/firmware/firmware.cfg
>> new file mode 100644
>> index 0000000..7331ab3
>> --- /dev/null
>> +++ b/meta/cfg/kernel-cache/features/firmware/firmware.cfg
>> @@ -0,0 +1,8 @@
>> +CONFIG_FW_LOADER=m
>> +CONFIG_FIRMWARE_IN_KERNEL=y
>> +CONFIG_EXTRA_FIRMWARE=""
>> +
>> +#
>> +# Altera FPGA firmware download module
>> +#
>> +CONFIG_ALTERA_STAPL=m
>> diff --git a/meta/cfg/kernel-cache/features/firmware/firmware.scc b/meta/cfg/kernel-cache/features/firmware/firmware.scc
>> new file mode 100644
>> index 0000000..09432a8
>> --- /dev/null
>> +++ b/meta/cfg/kernel-cache/features/firmware/firmware.scc
>> @@ -0,0 +1,4 @@
>> +define KFEATURE_DESCRIPTION "Firmware loading support"
>> +define KFEATURE_COMPATIBILITY all
>> +
>> +kconf non-hardware firmware.cfg
>