[linux-yocto] [PATCH 05/16] media/common : A feature for common media support

[Hart, Darren]

On Fri, 2013-11-22 at 11:35 -0800, nitin.a.kamble at intel.com wrote:
> From: Nitin A Kamble <nitin.a.kamble at intel.com>
> 
> This enables the kernel configuration for media support common to
> some PCI and USB media devices.

> Signed-off-by: Nitin A Kamble <nitin.a.kamble at intel.com>
> ---
>  meta/cfg/kernel-cache/features/media/common.cfg | 15 +++++++++++++++
>  meta/cfg/kernel-cache/features/media/common.scc |  6 ++++++
>  2 files changed, 21 insertions(+)
>  create mode 100644 meta/cfg/kernel-cache/features/media/common.cfg
>  create mode 100644 meta/cfg/kernel-cache/features/media/common.scc
> 
> diff --git a/meta/cfg/kernel-cache/features/media/common.cfg b/meta/cfg/kernel-cache/features/media/common.cfg
> new file mode 100644
> index 0000000..bb5db0b
> --- /dev/null
> +++ b/meta/cfg/kernel-cache/features/media/common.cfg
> @@ -0,0 +1,15 @@
> +#
> +# Media Common Options
> +#
> +CONFIG_MEDIA_COMMON_OPTIONS=y

This, for example, does not have a prompt, which means it is not
manually selected, which means it is selected by the menu options that
need it, which means it doesn't need to be explicitly mentioned in the
fragment. In fact, these should not be listed as they are just more
meta-data to audit on kernel upgrades. I leave these out of fragments
entirely.

The Kconfig for this option:

  │ Symbol: MEDIA_COMMON_OPTIONS [=n]                                           │  
  │ Type  : boolean                                                             │  
  │   Defined at drivers/media/common/Kconfig:2                                 │  
  │   Depends on: MEDIA_SUPPORT [=y]                                            │  
  │   Selected by: SMS_SDIO_DRV [=n] && MEDIA_SUPPORT [=y] && DVB_CORE [=n] &&


> +
> +CONFIG_DVB_B2C2_FLEXCOP=m
> +CONFIG_VIDEO_SAA7146=m
> +CONFIG_VIDEO_SAA7146_VV=m
> +CONFIG_SMS_SIANO_MDTV=m

Also no prompt for the above.

> +CONFIG_SMS_SIANO_RC=y

This is not a common feature, this is very specific to Siano devices and
should be either paired with those devices are as part of the rc
fragment.

> +
> +CONFIG_VIDEO_BTCX=m
> +CONFIG_VIDEO_TVEEPROM=m

No prompts.

So, move the SMS_SIANO_RC to rc and this fragment can be eliminated
entirely.

--
Darren


> diff --git a/meta/cfg/kernel-cache/features/media/common.scc b/meta/cfg/kernel-cache/features/media/common.scc
> new file mode 100644
> index 0000000..e3df51d
> --- /dev/null
> +++ b/meta/cfg/kernel-cache/features/media/common.scc
> @@ -0,0 +1,6 @@
> +define KFEATURE_DESCRIPTION "Enable Common Media Options"
> +define KFEATURE_COMPATIBILITY all
> +
> +include media.scc
> +
> +kconf hardware common.cfg

-- 
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel