[linux-yocto] [PATCH 69/94] arm/mach-axxia: Fixed type1 PCIe enumeration issue

Bruce Ashfield bruce.ashfield at windriver.com
Sat Nov 9 07:57:18 PST 2013


On 11/7/2013, 8:13 PM, Paul Butler wrote:
> From: SangeethaRao <sangeetha.rao at lsi.com>

Obviously the masking and shifting isn't necessary. But is there a
description of the issues that the masking and shifting was causing ?
It'll save some poor soul that might not have the latest code some
time, if it is logged in the commit.

Bruce

>
> Signed-off-by: SangeethaRao <sangeetha.rao at lsi.com>
> ---
>   arch/arm/mach-axxia/pci.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-axxia/pci.c b/arch/arm/mach-axxia/pci.c
> index b0ddab6..2600892 100644
> --- a/arch/arm/mach-axxia/pci.c
> +++ b/arch/arm/mach-axxia/pci.c
> @@ -209,8 +209,8 @@ axxia_pciex_get_config_base(struct axxia_pciex_port *port,
>   		return port->regs;
>
>   	relbus = bus->number - (port->root_bus_nr + 1);
> -	dev    = (PCI_SLOT(devfn) & 0xf8) >> 3;
> -	fn     = (PCI_FUNC(devfn) & 0x7);
> +	dev    = PCI_SLOT(devfn);
> +	fn     = PCI_FUNC(devfn);
>
>   	if (dev > 31)
>   		return NULL;
>




More information about the linux-yocto mailing list