[linux-yocto] [PATCH 08/87] drivers/usb/host/ehci-ci13612.c: replaced bugzilla comments

Paul Butler butler.paul at gmail.com
Tue May 28 13:00:06 PDT 2013


On Mon, May 27, 2013 at 02:00:01PM -0400, Bruce Ashfield wrote:
> On 13-05-27 12:55 PM, Paul Butler wrote:
> >Signed-off-by: Paul Butler <paul.butler at windriver.com>
> 
> Why wasn't this squashed into patch 4/87 ?

Multiple people were working on things and the customer was requesting
urgent updates. As we found something we made a quick change and pushed
it to them. We should now consolidate these usb driver updates into a single
or squashed commit?  04/87, 08/87, 09/87, and a few more.

> 
> Bruce
> 
> >---
> >  drivers/usb/host/ehci-ci13612.c | 7 +++----
> >  1 file changed, 3 insertions(+), 4 deletions(-)
> >
> >diff --git a/drivers/usb/host/ehci-ci13612.c b/drivers/usb/host/ehci-ci13612.c
> >index 5d3a6bc..151376c 100644
> >--- a/drivers/usb/host/ehci-ci13612.c
> >+++ b/drivers/usb/host/ehci-ci13612.c
> >@@ -27,13 +27,12 @@
> >  #include "ehci-ci13612.h"
> >
> >
> >-/* Patch the code to fix the bugs in Bugzilla */
> >  static void ci13612_usb_setup(struct usb_hcd *hcd)
> >  {
> >  	int USB_TXFIFOTHRES, VUSB_HS_TX_BURST;
> >
> >-	/* fix Bugzilla #31874 */
> >-	/* fix Bugzilla #32212 */
> >+	/* Fix a HW erratum where the USB core may overrun its transmit FIFO. */
> >+	/* Fix a HW erratum where the USB core may incorrectly fill its transmit FIFO. */
> >  	VUSB_HS_TX_BURST = inl(USB_HWTXBUF) & 0x0f;
> >  	USB_TXFIFOTHRES = (inl(USB_TXFILLTUNING) & 0x3f0000) >> 16;
> >
> >@@ -94,7 +93,7 @@ static int ehci_run_fix(struct usb_hcd *hcd)
> >  	unsigned burst_size;
> >  	int retval;
> >
> >-	/* fix Bugzilla 33669 */
> >+	/* Fix a HW erratum during the USB reset process. */
> >  	port_status = ehci_readl(ehci, &ehci->regs->port_status[0]);
> >  	printk(KERN_INFO "ehci_run: port_status = 0x%x\n", port_status);
> >  	if (port_status & 0x100) {
> >
> 



More information about the linux-yocto mailing list