[linux-yocto] [yocto][PATCH] mfd: omap-usb-host: Don't spam console on clk_set_parent failure

[Bruce Ashfield]

On 13-05-21 3:40 PM, Simarpreet Singh wrote:
> From: Roger Quadros <rogerq at ti.com>
>
> commit a8c4e9e1118f0a12e3a9524d8d597487d7e3476d upstream
>
> clk_set_parent is expected to fail on OMAP3 platforms. We don't
> consider that as fatal so don't spam console.
>
> Signed-off-by: Roger Quadros <rogerq at ti.com>
> Reviewed-by: Felipe Balbi <balbi at ti.com>
> [SS:  minor updates to context]
> Signed-off-by: Simarpreet Singh <simarpreet.singh at windriver.com>
> ---
> yocto-bugfix: https://bugzilla.yoctoproject.org/show_bug.cgi?id=3936
>
> This patch fixes the error messages in the kernel-ring-buffer at bootup.
> The messages are expected as on OMAP3, clk_set_parent fails. The messages
> shouldn't be flagged as errors but instead should be sent to dev_dbg.
>
> More Info: https://lkml.org/lkml/2013/1/16/297

Looks good. Thanks for the fixed, merge into the 3.4 tree and it will
go out with the rest of my -stable updates.

Bruce

>
> Testing was done by re-compiling the kernel and doing:
> dmesg | grep error, as the bugrepoter had suggested.
>
>   drivers/mfd/omap-usb-host.c |   18 +++++++++---------
>   1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/mfd/omap-usb-host.c b/drivers/mfd/omap-usb-host.c
> index 7e96bb2..e287897 100644
> --- a/drivers/mfd/omap-usb-host.c
> +++ b/drivers/mfd/omap-usb-host.c
> @@ -699,32 +699,32 @@ static int __devinit usbhs_omap_probe(struct platform_device *pdev)
>   	}
>
>   	if (is_ehci_phy_mode(pdata->port_mode[0])) {
> -		/* for OMAP3 , the clk set paretn fails */
> +		/* for OMAP3, clk_set_parent fails */
>   		ret = clk_set_parent(omap->utmi_p1_fck,
>   					omap->xclk60mhsp1_ck);
>   		if (ret != 0)
> -			dev_err(dev, "xclk60mhsp1_ck set parent"
> -				"failed error:%d\n", ret);
> +			dev_dbg(dev, "xclk60mhsp1_ck set parent failed: %d\n",
> +					ret);
>   	} else if (is_ehci_tll_mode(pdata->port_mode[0])) {
>   		ret = clk_set_parent(omap->utmi_p1_fck,
>   					omap->init_60m_fclk);
>   		if (ret != 0)
> -			dev_err(dev, "init_60m_fclk set parent"
> -				"failed error:%d\n", ret);
> +			dev_dbg(dev, "P0 init_60m_fclk set parent failed: %d\n",
> +					ret);
>   	}
>
>   	if (is_ehci_phy_mode(pdata->port_mode[1])) {
>   		ret = clk_set_parent(omap->utmi_p2_fck,
>   					omap->xclk60mhsp2_ck);
>   		if (ret != 0)
> -			dev_err(dev, "xclk60mhsp2_ck set parent"
> -					"failed error:%d\n", ret);
> +			dev_dbg(dev, "xclk60mhsp2_ck set parent failed: %d\n",
> +					ret);
>   	} else if (is_ehci_tll_mode(pdata->port_mode[1])) {
>   		ret = clk_set_parent(omap->utmi_p2_fck,
>   						omap->init_60m_fclk);
>   		if (ret != 0)
> -			dev_err(dev, "init_60m_fclk set parent"
> -				"failed error:%d\n", ret);
> +			dev_dbg(dev, "P1 init_60m_fclk set parent failed: %d\n",
> +					ret);
>   	}
>
>   	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "uhh");
>