[eclipse-yocto] setup.sh patches for #13050

[Ang, Chin Huat]

Hi Tim,

I've updated the patches to generate trace.ini when -q or --quiet is not set.

Just as before, the follow patches:

  * neon-master, v3 [1]
  * oxygen-master, v3 [2]
  * master, v2 [3]

... have also been rebased (as necessary) and pushed to the following eclipse-yocto-contrib branches:

  * cha/yocto-13050-neon-master [4]
  * cha/yocto-13050-oxygen-master [5]
  * cha/yocto-13050-master [6]

--Chin Huat

[1] https://lists.yoctoproject.org/pipermail/eclipse-yocto/2019-January/000245.html
[2] https://lists.yoctoproject.org/pipermail/eclipse-yocto/2019-January/000250.html
[3] https://lists.yoctoproject.org/pipermail/eclipse-yocto/2019-January/000256.html
[4] http://git.yoctoproject.org/cgit/cgit.cgi/eclipse-yocto-contrib/log/?h=cha/yocto-13050-neon-master
[5] http://git.yoctoproject.org/cgit/cgit.cgi/eclipse-yocto-contrib/log/?h=cha/yocto-13050-oxygen-master
[6] http://git.yoctoproject.org/cgit/cgit.cgi/eclipse-yocto-contrib/log/?h=cha/yocto-13050-master
________________________________________
From: Tim Orling [timothy.t.orling at linux.intel.com]
Sent: Friday, January 11, 2019 1:59 PM
To: Tim Orling
Cc: Ang, Chin Huat; Orling, Timothy T; eclipse-yocto at yoctoproject.org
Subject: Re: [eclipse-yocto] setup.sh patches for #13050

This [1]:
[ "$P2_INSTALL_TRACE" == "1" ] && TRACE_OPTS="-debug ./trace.ini”

means that you are forcing the user to run the setup.sh script from within the scripts directory (e.g. `cd ./scripts && ./setup.sh`). I have always run `./scripts/setup.sh`. Yes, the auto builder job does `cd ./scripts && ./setup.sh`, but we should always try to make our scripts be path agnostic.

Also, rather than include the trace.ini file, echo it to `pwd`/trace.ini, similar to what you did with [2]:

[ $USE_UPSTREAM -eq 0 ] && echo "eclipse.p2.mirrors=false" >> eclipse/configuration/config.ini


It is slightly more complicated than that, but I accidentally wiped out my PoC of doing it with echo in the setup.sh script. I will try to recreate that change and post in another email (tomorrow or so), unless the following is enough guidance for you ?

Essentially what I had was checking for the value of P2_INSTALL_TRACE=1 and then checking if `pwd`/trace.ini already existed (deleting it) and then (re)creating it with

echo "org.eclipse.equinox.p2.core/debug=true” > `pwd`/trace.ini
echo “org.eclipse.equinox.p2.core/artifacts/mirrors=true” >> `pwd`/trace.ini

This also means that on line 281 it becomes TRACE_OPTS="-debug `pwd`/trace.ini"

[1] http://git.yoctoproject.org/cgit/cgit.cgi/eclipse-yocto-contrib/tree/scripts/setup.sh?h=cha/yocto-13050-oxygen-master#n281

[2] http://git.yoctoproject.org/cgit/cgit.cgi/eclipse-yocto-contrib/tree/scripts/setup.sh?h=cha/yocto-13050-oxygen-master#n172


> On Dec 18, 2018, at 9:18 PM, Tim Orling <ticotimo at gmail.com> wrote:
>
> Thank you, i’ll have a look in the morning.
>
> On Tue, Dec 18, 2018 at 9:14 PM Ang, Chin Huat <chin.huat.ang at intel.com> wrote:
> For convenience, the patches submitted earlier targeting the following branches:
>
>   * neon-master [1]
>   * oxygen-master [2]
>   * master [3]
>
> can also be found at the following eclipse-yocto-contrib branches:
>
>   * cha/yocto-13050-neon-master [4]
>   * cha/yocto-13050-oxygen-master [5]
>   * cha/yocto-13050-master [6]
>
> --Chin Huat
>
>
> [1] https://lists.yoctoproject.org/pipermail/eclipse-yocto/2018-December/000224.html
> [2] https://lists.yoctoproject.org/pipermail/eclipse-yocto/2018-December/000227.html
> [3] https://lists.yoctoproject.org/pipermail/eclipse-yocto/2018-December/000231.html
> [4] http://git.yoctoproject.org/cgit/cgit.cgi/eclipse-yocto-contrib/log/?h=cha/yocto-13050-neon-master
> [5] http://git.yoctoproject.org/cgit/cgit.cgi/eclipse-yocto-contrib/log/?h=cha/yocto-13050-oxygen-master
> [6] http://git.yoctoproject.org/cgit/cgit.cgi/eclipse-yocto-contrib/log/?h=cha/yocto-13050-master
> _______________________________________________
> eclipse-yocto mailing list
> eclipse-yocto at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/eclipse-yocto
> _______________________________________________
> eclipse-yocto mailing list
> eclipse-yocto at yoctoproject.org
> https://lists.yoctoproject.org/listinfo/eclipse-yocto